Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: authentication #2531

Merged
merged 3 commits into from
Dec 21, 2018
Merged

example: authentication #2531

merged 3 commits into from
Dec 21, 2018

Conversation

lyuxuan
Copy link
Contributor

@lyuxuan lyuxuan commented Dec 21, 2018

No description provided.

menghanl
menghanl reviewed Dec 21, 2018
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the old directory, and leave a README.md with the new location.
No, let's not keep the old directory. I don't think many people are referring to it.

examples/features/authentication/oauth/server/main.go Outdated
func main() {
log.Println("server starting on port 8080...")
flag.Parse()
log.Printf("server starting on port %d...\n", *port)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fmt.Printf

@lyuxuan lyuxuan merged commit 2cb2074 into grpc:master Dec 21, 2018
@lyuxuan lyuxuan mentioned this pull request Dec 22, 2018
Closed
@menghanl menghanl added this to the 1.18 Release milestone Dec 27, 2018
@menghanl menghanl added the Type: Documentation Documentation or examples label Dec 27, 2018
@menghanl menghanl changed the title example: authentication example: authentication Jan 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@lyuxuan @menghanl